Soudex: Fix PR feedback

xrash · Dec 13, 2023 · 0e44fa3 · 0e44fa3
1 parent 336b7ec
commit 0e44fa3
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 25 deletions.
diff --git a/go.mod b/go.mod
diff --git a/soundex.go b/soundex.go
@@ -13,10 +13,6 @@ func Soundex(s string) string {
 	if p <= 'z' && p >= 'a' {
 		p -= 32 // convert to uppercase
 	}
-	if p < 'A' || p > 'Z' {
-		// invalid first letter
-		return "0000"
-	}
 	b.WriteByte(p)
 
 	n := 0

diff --git a/tests/soundex_test.go b/tests/soundex_test.go
@@ -6,24 +6,6 @@ import (
 	"testing"
 )
 
-//func BenchmarkSoundex(b *testing.B) {
-//	fd, err := os.Open("testdata/english_names.txt")
-//	if err != nil {
-//		b.Fatal(err)
-//	}
-//	defer fd.Close()
-//
-//	scanner := bufio.NewScanner(fd)
-//	for scanner.Scan() {
-//		s := smetrics.Soundex(scanner.Text())
-//
-//		// Trivially use the result to avoid compiler optimizations.
-//		if len(s) != 4 {
-//			b.Fail()
-//		}
-//	}
-//}
-
 func TestSoundex(t *testing.T) {
 	cases := []soundexcase{
 		{"Euler", "E460"},