Merge pull request nickbutcher#77 from mattprecious/mattp/unsuccessfu…

…l-response Check response status before reading body
xsobolx · Mar 29, 2016 · 64977f6 · 64977f6
2 parents b5be97b + 6048bf0
commit 64977f6
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/app/src/main/java/io/plaidapp/data/api/dribbble/ShotLikesDataManager.java b/app/src/main/java/io/plaidapp/data/api/dribbble/ShotLikesDataManager.java
@@ -52,15 +52,23 @@ protected void loadData(int page) {
 
             @Override
             public void onResponse(Call<List<Like>> call, Response<List<Like>> response) {
-                loadFinished();
-                final List<Like> likes = response.body();
-                moreDataAvailable = likes.size() == DribbbleService.PER_PAGE_DEFAULT;
-                onDataLoaded(likes);
-                shotLikesCall = null;
+                if (response.isSuccessful()) {
+                    loadFinished();
+                    final List<Like> likes = response.body();
+                    moreDataAvailable = likes.size() == DribbbleService.PER_PAGE_DEFAULT;
+                    onDataLoaded(likes);
+                    shotLikesCall = null;
+                } else {
+                    failure();
+                }
             }
 
             @Override
             public void onFailure(Call<List<Like>> call, Throwable t) {
+                failure();
+            }
+
+            private void failure() {
                 loadFinished();
                 moreDataAvailable = false;
                 shotLikesCall = null;