Miscellaneous bug fixes (thrasher-corp#513)

* Various bug fixes

* Deadlink, cleanup plus bug fixes

* Various Kraken fixes

* Add convert func for decimal unix timestamps

* Convert all test times to UTC

* Kraken: Make assets a pointer to prevent excessive copying

* Docker slash fix

* Address nits plus bump ITBit last checked pairs timestamp

* Set pairs to enabled pairs when getting active orders

* Use asset translator for UpdateAccountInfo and more checks for the exchange template tool

* Address MadCozBadd's nits

* Make exchange var 2 chars

* Make program more user friendly

* Project wide comment checks and exchName check

* Fix Huobi indexing bug and use correct pair formatting

* Address nits + readme change

CONTRIBUTORS

@@ -3,13 +3,14 @@ Thanks to the following contributors:
 thrasher- | https://github.com/thrasher-
 shazbert | https://github.com/shazbert
 gloriousCode | https://github.com/gloriousCode
-xtda | https://github.com/xtda
 dependabot-preview[bot] | https://github.com/apps/dependabot-preview
+xtda | https://github.com/xtda
 ermalguni | https://github.com/ermalguni
 vadimzhukck | https://github.com/vadimzhukck
+MadCozBadd | https://github.com/MadCozBadd
 140am | https://github.com/140am
 marcofranssen | https://github.com/marcofranssen
-MadCozBadd | https://github.com/MadCozBadd
+dackroyd | https://github.com/dackroyd
 cranktakular | https://github.com/cranktakular
 woshidama323 | https://github.com/woshidama323
 vazha | https://github.com/vazha
@@ -29,7 +30,6 @@ CodeLingoBot | https://github.com/CodeLingoBot
 CodeLingoTeam | https://github.com/CodeLingoTeam
 Daanikus | https://github.com/Daanikus
 daniel-cohen | https://github.com/daniel-cohen
-merkeld | https://github.com/merkeld
 DirectX | https://github.com/DirectX
 frankzougc | https://github.com/frankzougc
 idoall | https://github.com/idoall
@@ -41,3 +41,4 @@ zeldrinn | https://github.com/zeldrinn
 starit | https://github.com/starit
 Jimexist | https://github.com/Jimexist
 lookfirst | https://github.com/lookfirst
+merkeld | https://github.com/merkeld

Dockerfile

@@ -13,6 +13,6 @@ VOLUME /root/.gocryptotrader
 RUN apk update && apk add --no-cache ca-certificates bash
 COPY --from=build /go/bin/gocryptotrader /app/
 COPY --from=build /go/bin/gctcli /app/
-COPY --from=build /go/src/github.com/thrasher-corp/gocryptotrader/config.json /app/
+COPY --from=build /go/src/github.com/thrasher-corp/gocryptotrader/config.json /root/.gocryptotrader/
 EXPOSE 9050-9053
 ENTRYPOINT [ "/app/gocryptotrader" ]

README.md

@@ -47,9 +47,10 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Yobit | Yes | NA | NA |
 | ZB.COM | Yes | Yes | NA |
 
-We are aiming to support the top 20 highest volume exchanges based off the [CoinMarketCap exchange data](https://coinmarketcap.com/exchanges/volume/24-hour/).
+We are aiming to support the top 30 exchanges sorted by average liquidity as [ranked by CoinMarketCap](https://coinmarketcap.com/rankings/exchanges/). 
+However, we welcome pull requests for any exchange which does not match this criterion. If you need help with this, please join us on [Slack](https://join.slack.com/t/gocryptotrader/shared_invite/enQtNTQ5NDAxMjA2Mjc5LTc5ZDE1ZTNiOGM3ZGMyMmY1NTAxYWZhODE0MWM5N2JlZDk1NDU0YTViYzk4NTk3OTRiMDQzNGQ1YTc4YmRlMTk).
 
-** NA means not applicable as the Exchange does not support the feature.
+** NA means not applicable as the exchange does not support the feature.
 
 ## Current Features
 
@@ -138,16 +139,17 @@ Binaries will be published once the codebase reaches a stable condition.
 
 |User|Contribution Amount|
 |--|--|
-| [thrasher-](https://github.com/thrasher-) | 637 |
-| [shazbert](https://github.com/shazbert) | 188 |
-| [gloriousCode](https://github.com/gloriousCode) | 167 |
-| [xtda](https://github.com/xtda) | 42 |
-| [dependabot-preview[bot]](https://github.com/apps/dependabot-preview) | 23 |
+| [thrasher-](https://github.com/thrasher-) | 639 |
+| [shazbert](https://github.com/shazbert) | 191 |
+| [gloriousCode](https://github.com/gloriousCode) | 169 |
+| [dependabot-preview[bot]](https://github.com/apps/dependabot-preview) | 46 |
+| [xtda](https://github.com/xtda) | 43 |
 | [ermalguni](https://github.com/ermalguni) | 14 |
 | [vadimzhukck](https://github.com/vadimzhukck) | 10 |
+| [MadCozBadd](https://github.com/MadCozBadd) | 8 |
 | [140am](https://github.com/140am) | 8 |
 | [marcofranssen](https://github.com/marcofranssen) | 8 |
-| [MadCozBadd](https://github.com/MadCozBadd) | 7 |
+| [dackroyd](https://github.com/dackroyd) | 5 |
 | [cranktakular](https://github.com/cranktakular) | 5 |
 | [woshidama323](https://github.com/woshidama323) | 3 |
 | [vazha](https://github.com/vazha) | 3 |
@@ -167,7 +169,6 @@ Binaries will be published once the codebase reaches a stable condition.
 | [CodeLingoTeam](https://github.com/CodeLingoTeam) | 1 |
 | [Daanikus](https://github.com/Daanikus) | 1 |
 | [daniel-cohen](https://github.com/daniel-cohen) | 1 |
-| [merkeld](https://github.com/merkeld) | 1 |
 | [DirectX](https://github.com/DirectX) | 1 |
 | [frankzougc](https://github.com/frankzougc) | 1 |
 | [idoall](https://github.com/idoall) | 1 |
@@ -179,3 +180,4 @@ Binaries will be published once the codebase reaches a stable condition.
 | [starit](https://github.com/starit) | 1 |
 | [Jimexist](https://github.com/Jimexist) | 1 |
 | [lookfirst](https://github.com/lookfirst) | 1 |
+| [merkeld](https://github.com/merkeld) | 1 |

cmd/documentation/documentation.go

@@ -226,6 +226,11 @@ func main() {
 				URL:           "https://github.com/lookfirst",
 				Contributions: 1,
 			},
+			{
+				Login:         "merkeld",
+				URL:           "https://github.com/merkeld",
+				Contributions: 1,
+			},
 		}...)
 
 		if verbose {

cmd/documentation/root_templates/root_readme.tmpl

@@ -48,9 +48,10 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Yobit | Yes | NA | NA |
 | ZB.COM | Yes | Yes | NA |
 
-We are aiming to support the top 20 highest volume exchanges based off the [CoinMarketCap exchange data](https://coinmarketcap.com/exchanges/volume/24-hour/).
+We are aiming to support the top 30 exchanges sorted by average liquidity as [ranked by CoinMarketCap](https://coinmarketcap.com/rankings/exchanges/). 
+However, we welcome pull requests for any exchange which does not match this criterion. If you need help with this, please join us on [Slack](https://join.slack.com/t/gocryptotrader/shared_invite/enQtNTQ5NDAxMjA2Mjc5LTc5ZDE1ZTNiOGM3ZGMyMmY1NTAxYWZhODE0MWM5N2JlZDk1NDU0YTViYzk4NTk3OTRiMDQzNGQ1YTc4YmRlMTk).
 
-** NA means not applicable as the Exchange does not support the feature.
+** NA means not applicable as the exchange does not support the feature.
 
 ## Current Features