forked from netty/netty
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PromiseNotifier does not propagate cancel events
Motivation: If the Future that the PromiseNotifier is listening to is cancelled, it does not propagate the cancel to all the promises it is expected to notify. Modifications: - If the future is cancelled then all the promises should be cancelled - Add a UnaryPromiseNotifier if a collection of promises is not necessary Result: PromiseNotifier propagates cancel events to all promises
- Loading branch information
1 parent
6e9d2bf
commit 050ac70
Showing
3 changed files
with
64 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
common/src/main/java/io/netty/util/concurrent/UnaryPromiseNotifier.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright 2016 The Netty Project | ||
* | ||
* The Netty Project licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package io.netty.util.concurrent; | ||
|
||
import io.netty.util.internal.ObjectUtil; | ||
import io.netty.util.internal.logging.InternalLogger; | ||
import io.netty.util.internal.logging.InternalLoggerFactory; | ||
|
||
public final class UnaryPromiseNotifier<T> implements FutureListener<T> { | ||
private static final InternalLogger logger = InternalLoggerFactory.getInstance(UnaryPromiseNotifier.class); | ||
private final Promise<? super T> promise; | ||
|
||
public UnaryPromiseNotifier(Promise<? super T> promise) { | ||
this.promise = ObjectUtil.checkNotNull(promise, "promise"); | ||
} | ||
|
||
@Override | ||
public void operationComplete(Future<T> future) throws Exception { | ||
cascadeTo(future, promise); | ||
} | ||
|
||
public static <X> void cascadeTo(Future<X> completedFuture, Promise<? super X> promise) { | ||
if (completedFuture.isSuccess()) { | ||
if (!promise.trySuccess(completedFuture.getNow())) { | ||
logger.warn("Failed to mark a promise as success because it is done already: {}", promise); | ||
} | ||
} else if (completedFuture.isCancelled()) { | ||
if (!promise.cancel(false)) { | ||
logger.warn("Failed to cancel a promise because it is done already: {}", promise); | ||
} | ||
} else { | ||
if (!promise.tryFailure(completedFuture.cause())) { | ||
logger.warn("Failed to mark a promise as failure because it's done already: {}", promise, | ||
completedFuture.cause()); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters