Skip to content

Commit

Permalink
Make this test meaningful
Browse files Browse the repository at this point in the history
We're not only checking that hash_update_file() succeeds, but rather
that it properly works.

Furthermore, we fix the SKIPIF section – we don't need mhash to run the
test, and we don't need to check for unsupported PHP versions.

We also shorten the test name to avoid cluttering the test reports with
unnecessary detail.
  • Loading branch information
cmb69 committed Oct 18, 2016
1 parent b7fe687 commit 35b19cd
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions ext/hash/tests/hash_update_file.phpt
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
--TEST--
bool hash_update_file ( resource $hcontext , string $filename [, resource $scontext = NULL ] );
hash_update_file() function - basic test
--CREDITS--
marcosptf - <[email protected]> - @phpsp - sao paulo - br
--SKIPIF--
<?php
if (phpversion() < "5.3.0") {
die('SKIP php version so lower.');
}
require_once(dirname(__FILE__) . '/skip_mhash.inc'); ?>
if (!extension_loaded('hash')) die('skip hash extension not available');
?>
--FILE--
<?php
$filePath = __DIR__ . DIRECTORY_SEPARATOR . 'hash_update_stream.txt';
file_put_contents($filePath, 'The quick brown fox jumped over the lazy dog.');

$ctx = hash_init('md5');
$filePath = __DIR__ . DIRECTORY_SEPARATOR . 'sha1.phpt';
fopen($filePath, "r");
var_dump(hash_update_file($ctx, $filePath));
hash_final($ctx);
echo hash_final($ctx);
?>
--EXPECT--
bool(true)
5c6ffbdd40d9556b73a21e63c3e0e904
--CLEAN--
<?php
unlink(__DIR__ . DIRECTORY_SEPARATOR . 'hash_update_stream.txt');
?>

0 comments on commit 35b19cd

Please sign in to comment.