Skip to content

Commit

Permalink
Remove helm package -u in favor of helm package (istio#11769)
Browse files Browse the repository at this point in the history
This work removes the ability to include packages from
external helm repositories.  This is to remove the
`helm dep update` step.

The hidden implication here is that CNI must be installed
indepently but still enabled in the chart for it to be used.

Not installing the CNI chart or manifest while enabling CNI
will result in sidecar injector failures.
  • Loading branch information
sdake authored and wenchenglu committed Feb 15, 2019
1 parent 70f3993 commit 7008148
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions release/gcb/helm_charts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,12 @@ CHARTS=(
# Prepare helm setup
mkdir -vp "$HELM_DIR"
$HELM init --client-only
$HELM repo add istio.io https://storage.googleapis.com/istio-prerelease/daily-build/master-latest-daily/charts

# Create a package for each charts and build the repo index.
mkdir -vp "$HELM_BUILD_DIR"
for CHART_PATH in "${CHARTS[@]}"
do
$HELM package -u "$CHART_PATH" -d "$HELM_BUILD_DIR"
$HELM package "$CHART_PATH" -d "$HELM_BUILD_DIR"
done

$HELM repo index "$HELM_BUILD_DIR"
Expand Down

0 comments on commit 7008148

Please sign in to comment.