[bugfix] Popup: should remove touch event listener when distroyed (yo…

…uzan#912)
xuxiaoxiao312 · Apr 23, 2018 · d92edf8 · d92edf8
1 parent cbdaaf4
commit d92edf8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/mixins/popup/index.js b/packages/mixins/popup/index.js
@@ -88,10 +88,10 @@ export default {
       this.renderOverlay();
 
       if (this.lockScroll) {
+        on(document, 'touchstart', this.touchStart);
+        on(document, 'touchmove', this.onTouchMove);
         if (!context.lockCount) {
           document.body.classList.add('van-overflow-hidden');
-          on(document, 'touchstart', this.touchStart);
-          on(document, 'touchmove', this.onTouchMove);
         }
         context.lockCount++;
       }
@@ -104,10 +104,10 @@ export default {
 
       if (this.lockScroll) {
         context.lockCount--;
+        off(document, 'touchstart', this.touchStart);
+        off(document, 'touchmove', this.onTouchMove);
         if (!context.lockCount) {
           document.body.classList.remove('van-overflow-hidden');
-          off(document, 'touchstart', this.touchStart);
-          off(document, 'touchmove', this.onTouchMove);
         }
       }