Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken alembic import with alembic 1.15. Solves issue #368 #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: broken alembic import with alembic 1.15. Solves issue #368 #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Changelog

## [Unreleased]
### Fixed
- Broken alembic import with alembic 1.15. Solves issue [#368](https://github.com/xzkostyan/clickhouse-sqlalchemy/issues/368)

## [0.3.2] - 2024-06-12
### Added
Expand Down
10 changes: 6 additions & 4 deletions clickhouse_sqlalchemy/alembic/comparators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from alembic.autogenerate import comparators
from alembic.autogenerate.compare import _compare_columns
from alembic.operations.ops import ModifyTableOps
from alembic.util.sqla_compat import _reflect_table as _alembic_reflect_table
from alembic.util import sqla_compat
from sqlalchemy import schema as sa_schema
from sqlalchemy import text

Expand Down Expand Up @@ -35,10 +35,12 @@ def _extract_to_table_name(create_table_query):


def _reflect_table(inspector, table):
if alembic_version >= (1, 11, 0):
return _alembic_reflect_table(inspector, table)
if alembic_version >= (1, 15, 0):
return inspector.reflect_table(table, None)
elif alembic_version >= (1, 11, 0):
return sqla_compat._reflect_table(inspector, table)
else:
return _alembic_reflect_table(inspector, table, None)
return sqla_compat._reflect_table(inspector, table, None)


@comparators.dispatch_for('schema', 'clickhouse')
Expand Down