Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

박스오피스II [STEP 2] Erick, kyungmin #105

Open
wants to merge 24 commits into
base: ic_9_kyungmin
Choose a base branch
from
Open

박스오피스II [STEP 2] Erick, kyungmin #105

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e0a51ed
♻️Refactor: errorAlert을 재사용하기 쉽도록 customAlert으로 수정
h-suo Aug 15, 2023
9414154
✨Feat: toolbar 세팅 및 barButton 생성
h-suo Aug 15, 2023
b757f78
🚚build: BoxOfficeCollectionViewListCell 리네임
YaRkyungmin Aug 15, 2023
77215c4
✨Feat: BoxOfficeCollectionViewGridCell 구현
YaRkyungmin Aug 15, 2023
12918c9
🩹Chore: listCell 리네임
YaRkyungmin Aug 15, 2023
bbd3ff2
✨Feat: girdLayout메서드 추가 및 CollectionViewMode타입 구현
YaRkyungmin Aug 15, 2023
57a4c8d
✨Feat: 아이콘 및 리스트 모드로 변경하는 로직 구현
h-suo Aug 15, 2023
7fd2e4d
✨Feat: Dynamic Type 적용
YaRkyungmin Aug 15, 2023
b91361c
♻️Refactor: AutoShrink 적용
h-suo Aug 15, 2023
5d124a0
✨Feat: MovieDetailScrollView 다이나믹 타입 적용
h-suo Aug 15, 2023
e555577
♻️Refactor: minimumScaleFactor 수정
h-suo Aug 15, 2023
97b8d2b
♻️Refactor: 텍스트 크기가 커져도 titleLabel이 생략되지 않도록 설정
h-suo Aug 15, 2023
c6b8118
🩹Chore: 매직스트링 네임스페이스 분리
YaRkyungmin Aug 15, 2023
37524cd
🩹Chore: gridLayout 그룹 높이 조정
YaRkyungmin Aug 15, 2023
1ba9a90
♻️Refactor: 화면 모드 변경 로직 수정
h-suo Aug 15, 2023
9243927
♻️Refactor: 영화 상세보기 화면에서는 toolbar가 안 보이도록 설정
h-suo Aug 15, 2023
30daee2
♻️Refactor: rankStackView의 기본 너비 재설정
h-suo Aug 15, 2023
869dd61
🐛Fix: BoxOfficeViewController로 돌아올때 Toolbar 보이게 설정
YaRkyungmin Aug 15, 2023
c852eb4
♻️Refactor: CollectionViewMode 주입
YaRkyungmin Aug 17, 2023
7869c80
♻️Refactor: UICollectionViewLayout을 인자로 받도록 변경
h-suo Aug 17, 2023
749c7d6
🩹Chore: 컨벤션 수정
YaRkyungmin Aug 17, 2023
c06bc43
♻️Refactor: gridCell contentView의 masksToBounds 설정
h-suo Aug 17, 2023
5997921
♻️Refactor: informationStackView 제약 수정
YaRkyungmin Aug 17, 2023
553f24b
📝Docs: II-Step2 README 작성
h-suo Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
♻️Refactor: gridCell contentView의 masksToBounds 설정
  • Loading branch information
@h-suo
h-suo committed Aug 17, 2023
commit c06bc434f06dda0d5cefe22645ee771de8b1261a
1 change: 1 addition & 0 deletions BoxOffice/View/BoxOfficeCollectionViewGridCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ extension BoxOfficeCollectionViewGridCell {

private func setupContentView() {
contentView.layer.cornerRadius = 4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layer를 쓰셔서 질문드립니다.
MasksToBounds 는 뭘까요 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masksToBounds는 layer의 Bool 프로퍼티입니다.
true일때는 서브뷰들이 테두리를 기준으로 잘리게 되고, false일때는 잘리지 않게 됩니다.
기본값이 false이기 때문에 true로 변경해줬습니다☺️

contentView.layer.masksToBounds = true
contentView.layer.borderWidth = 2
contentView.layer.borderColor = UIColor.systemGray.cgColor

Expand Down