Fix worker hang

yangzheyulive · Feb 3, 2024 · 63c1055 · 63c1055
1 parent d41ab72
commit 63c1055
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/llava/serve/controller.py b/llava/serve/controller.py
@@ -61,7 +61,7 @@ def __init__(self, dispatch_method: str):
         self.dispatch_method = DispatchMethod.from_str(dispatch_method)
 
         self.heart_beat_thread = threading.Thread(
-            target=heart_beat_controller, args=(self,))
+            target=heart_beat_controller, args=(self,), daemon=True)
         self.heart_beat_thread.start()
 
         logger.info("Init controller")

diff --git a/llava/serve/model_worker.py b/llava/serve/model_worker.py
@@ -69,7 +69,7 @@ def __init__(self, controller_addr, worker_addr,
         if not no_register:
             self.register_to_controller()
             self.heart_beat_thread = threading.Thread(
-                target=heart_beat_worker, args=(self,))
+                target=heart_beat_worker, args=(self,), daemon=True)
             self.heart_beat_thread.start()
 
     def register_to_controller(self):

diff --git a/llava/serve/sglang_worker.py b/llava/serve/sglang_worker.py
@@ -79,7 +79,7 @@ def __init__(self, controller_addr, worker_addr, sgl_endpoint,
         if not no_register:
             self.register_to_controller()
             self.heart_beat_thread = threading.Thread(
-                target=heart_beat_worker, args=(self,))
+                target=heart_beat_worker, args=(self,), daemon=True)
             self.heart_beat_thread.start()
 
     def register_to_controller(self):