*: enable golangci-lint exportloopref (pingcap#28991)

yanweibing · Nov 1, 2021 · 3032d87 · 3032d87
1 parent 9621d73
commit 3032d87
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/.golangci.yml b/.golangci.yml
@@ -18,9 +18,9 @@ linters:
     - gosec
     - asciicheck
     - bodyclose
+    - exportloopref
     - rowserrcheck
     - unconvert
-
 linters-settings:
   staticcheck:
     checks: ["S1002","S1004","S1007","S1009","S1010","S1012","S1019","S1020","S1021","S1024","S1030","SA2*","SA3*","SA4009","SA5*","SA6000","SA6001","SA6005", "-SA2002"]

diff --git a/executor/show_placement.go b/executor/show_placement.go
@@ -203,6 +203,7 @@ func (e *ShowExec) fetchShowPlacementForPartition(ctx context.Context) (err erro
 
 	var partition *model.PartitionDefinition
 	for _, par := range tblInfo.Partition.Definitions {
+		par := par
 		if par.Name.L == e.Partition.L {
 			partition = &par
 			break

diff --git a/planner/core/find_best_task.go b/planner/core/find_best_task.go
@@ -1825,6 +1825,7 @@ func (ds *DataSource) convertToPointGet(prop *property.PhysicalProperty, candida
 	if ds.isPartition {
 		if pi := ds.tableInfo.GetPartitionInfo(); pi != nil {
 			for _, def := range pi.Definitions {
+				def := def
 				if def.ID == ds.physicalTableID {
 					partitionInfo = &def
 					break