Add Builder for ConnectorContext (Netflix#517)

yaohwu · Sep 20, 2022 · 15e8028 · 15e8028
1 parent 56af9f8
commit 15e8028
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/...n-server/src/main/java/com/netflix/metacat/common/server/connectors/ConnectorContext.java b/...n-server/src/main/java/com/netflix/metacat/common/server/connectors/ConnectorContext.java
@@ -15,7 +15,9 @@
 
 import com.netflix.metacat.common.server.properties.Config;
 import com.netflix.spectator.api.Registry;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
+import lombok.Builder;
 import lombok.Data;
 import org.springframework.context.ApplicationContext;
 
@@ -26,7 +28,8 @@
 /**
  * Connector Config.
  */
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+@Builder
 @Data
 public class ConnectorContext {
     /**
@@ -60,5 +63,23 @@ public class ConnectorContext {
     /**
      * Nested connector contexts.
      */
-    private final List<ConnectorContext> nestedConnectorContexts = Collections.emptyList();
+    private final List<ConnectorContext> nestedConnectorContexts;
+
+    /**
+     * Default Ctor.
+     *
+     * @param catalogName        the catalog name.
+     * @param catalogShardName   the catalog shard name
+     * @param connectorType      the connector type.
+     * @param config             the application config.
+     * @param registry           the registry.
+     * @param applicationContext the application context.
+     * @param configuration      the connector properties.
+     */
+    public ConnectorContext(final String catalogName, final String catalogShardName, final String connectorType,
+                            final Config config, final Registry registry,
+                            final ApplicationContext applicationContext, final Map<String, String> configuration) {
+        this(catalogName, catalogShardName, connectorType, config, registry,
+                applicationContext, configuration, Collections.emptyList());
+    }
 }
diff --git a/metacat-common-server/src/main/java/com/netflix/metacat/common/server/util/MetacatUtils.java b/metacat-common-server/src/main/java/com/netflix/metacat/common/server/util/MetacatUtils.java
@@ -49,7 +49,7 @@ public static List<File> listFiles(final File dir) {
      *
      * @param file Properties file.
      * @return A Map of properties.
-     * @throws Exception
+     * @throws Exception IOException on failure to load file.
      */
     public static Map<String, String> loadProperties(final File file) throws Exception {
         Preconditions.checkNotNull(file, "file is null");