FIX: tests now catch bug reported in BVLC#750 (in HDF5 output layer)

yaolubrain · Jul 28, 2014 · cbc507e · cbc507e
1 parent 7752032
commit cbc507e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/src/caffe/test/test_data/generate_sample_data.py b/src/caffe/test/test_data/generate_sample_data.py
@@ -14,7 +14,10 @@
 data = np.arange(total_size)
 data = data.reshape(num_rows, num_cols, height, width)
 data = data.astype('float32')
-label = np.arange(num_rows)[:, np.newaxis]
+
+# We had a bug where data was copied into label, but the tests weren't
+# catching it, so let's make label 1-indexed.
+label = 1 + np.arange(num_rows)[:, np.newaxis]
 label = label.astype('float32')
 
 print data

diff --git a/src/caffe/test/test_data/sample_data.h5 b/src/caffe/test/test_data/sample_data.h5
diff --git a/src/caffe/test/test_data/sample_data_2_gzip.h5 b/src/caffe/test/test_data/sample_data_2_gzip.h5
diff --git a/src/caffe/test/test_hdf5_output_layer.cpp b/src/caffe/test/test_hdf5_output_layer.cpp
@@ -62,7 +62,7 @@ void HDF5OutputLayerTest<TypeParam>::CheckBlobEqual(const Blob<Dtype>& b1,
     for (int c = 0; c < b1.channels(); ++c) {
       for (int h = 0; h < b1.height(); ++h) {
         for (int w = 0; w < b1.width(); ++w) {
-          EXPECT_EQ(b1.data_at(n, c, h, w), b1.data_at(n, c, h, w));
+          EXPECT_EQ(b1.data_at(n, c, h, w), b2.data_at(n, c, h, w));
         }
       }
     }