Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: leave symlinks alone when cleaning up #4316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: leave symlinks alone when cleaning up #4316

wants to merge 3 commits into from

Conversation

marionebl
Copy link
Contributor

@marionebl marionebl commented Apr 2, 2022 •
edited
Loading

What's the problem this PR addresses?

3.2.0 crashes with

Error: ENOTDIR: not a directory, rmdir '/<path>/node_modules'\n"

at the end of the linting phase.

...

How did you fix it?

PnpmLinker's removeIfEmpty now ignores symlinks
...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.
  • Cover fix with a test

@marionebl marionebl closed this Apr 2, 2022
@marionebl marionebl reopened this Apr 2, 2022
@marionebl marionebl force-pushed the dont-crash-symlink-modules branch from 9201f34 to 2265d13 Compare April 10, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marionebl