Fixed PxUsage lint (getodk#2598)

yaroing · Oct 4, 2018 · 1c9407e · 1c9407e
1 parent e0a156f
commit 1c9407e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/collect_app/src/main/res/layout/media_layout.xml b/collect_app/src/main/res/layout/media_layout.xml
@@ -23,15 +23,14 @@
             android:id="@+id/imageView"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:padding="2px"
             android:scaleType="fitStart"
             android:visibility="gone" />
 
         <TextView
             android:id="@+id/missingImage"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:padding="10px"
+            android:padding="4dp"
             android:visibility="gone"
             tools:text="media missing" />
     </LinearLayout>

diff --git a/collect_app/src/main/res/values/style.xml b/collect_app/src/main/res/values/style.xml
@@ -37,14 +37,14 @@
 
     <style name="MediaButtonStyle">
         <item name="android:background">#ddd</item>
-        <item name="android:paddingBottom">12px</item>
-        <item name="android:paddingLeft">22px</item>
-        <item name="android:paddingRight">22px</item>
-        <item name="android:paddingTop">12px</item>
-        <item name="android:layout_marginLeft">6px</item>
-        <item name="android:layout_marginTop">0px</item>
-        <item name="android:layout_marginRight">6px</item>
-        <item name="android:layout_marginBottom">0px</item>
+        <item name="android:paddingBottom">5dp</item>
+        <item name="android:paddingLeft">9dp</item>
+        <item name="android:paddingRight">9dp</item>
+        <item name="android:paddingTop">5dp</item>
+        <item name="android:layout_marginLeft">2dp</item>
+        <item name="android:layout_marginTop">0dp</item>
+        <item name="android:layout_marginRight">2dp</item>
+        <item name="android:layout_marginBottom">0dp</item>
     </style>
 
 </resources>
diff --git a/config/lint.xml b/config/lint.xml
@@ -29,6 +29,7 @@
     <issue id="IconLocation" severity="error"/>
     <issue id="UnknownIdInLayout" severity="error"/>
     <issue id="IconDuplicates" severity="error"/>
+    <issue id="PxUsage" severity="error"/>
     <issue id="UnusedNamespace" severity="error">
         <ignore path="res/values*"/>
     </issue>