Skip to content

Commit

Permalink
RN: Migrate from @fb-tools/sort-requires to lint/sort-imports
Browse files Browse the repository at this point in the history
Summary:
Migrates installation of the import-sorting ESLint rule from `fb-tools/sort-requires` (which exists in `xplat/js/tools/eslint-plugin`) to `lint/sort-imports` (which uses `eslint-plugin-lint` and exists in `xplat/js/react-native-github/tools/eslint/rules`).

The rationale for doing this is to enable all codebases in **fbource** to be able to reference the lint rule using the same name in suppression comments:

```
// eslint-disable-next-line lint/sort-imports
```

Reviewed By: bradzacher

Differential Revision: D40040579

fbshipit-source-id: 8a235a1cbff4e950c846ede6a43ffd9417fb5a53
  • Loading branch information
yungsters authored and facebook-github-bot committed Oct 4, 2022
1 parent 90f910b commit c4d4cf8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tools/hermes-parser/js/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
"editor.formatOnSave": true,
},
"eslint.autofixOnSave.ruleAllowlist": [
"@fb-tools/sort-requires",
"lint/sort-imports",
"prettier/prettier",
],
}

0 comments on commit c4d4cf8

Please sign in to comment.