Skip to content

Commit

Permalink
golanfci-lint: Increase timeout
Browse files Browse the repository at this point in the history
The time it takes for the linters to run seem to have a large
fluctuation range, between 4sec to over 10sec.

As there are no guarantees given for such jobs (e.g. CPU time), we are
left with increasing the timeout period.

This is mainly triggered by the instability (timeouts) on CI runs.
A possible alternative is to define resource requirements for jobs,
reducing the inconsistent run duration results.

Signed-off-by: Edward Haas <[email protected]>
  • Loading branch information
EdDev committed Jul 12, 2022
1 parent f41e6c5 commit 3232abc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ fmt: format
lint:
if [ $$(wc -l < tests/utils.go) -gt 3565 ]; then echo >&2 "do not make tests/utils longer"; exit 1; fi

hack/dockerized "golangci-lint run --timeout 10m --verbose \
hack/dockerized "golangci-lint run --timeout 20m --verbose \
pkg/network/domainspec/... \
tests/console/... \
tests/libnet/... \
Expand Down

0 comments on commit 3232abc

Please sign in to comment.