Skip to content

Commit

Permalink
Code review
Browse files Browse the repository at this point in the history
  • Loading branch information
fabienric committed Oct 28, 2013
1 parent c6776aa commit 6eb605e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<protobuf.version>2.5.0</protobuf.version>
<jackson.version>2.2.2</jackson.version>
<wire.version>1.0.1</wire.version>
<simplexml.version>2.7.1</simplexml.version>
<simplexml.version>2.7.1</simplexml.version>

<!-- Test Dependencies -->
<junit.version>4.10</junit.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class SimpleXMLConverter implements Converter {
private static final String CHARSET = "UTF-8";
private static final String MIME_TYPE = "application/xml; charset=" + CHARSET;

private Serializer serializer = null;
private final Serializer serializer;

public SimpleXMLConverter(Serializer serializer) {
this.serializer = serializer;
Expand All @@ -45,10 +45,6 @@ public TypedOutput toBody(Object source) {
serializer.write(source, osw);
osw.flush();
return new TypedByteArray(MIME_TYPE, bos.toByteArray());
} catch (final NullPointerException e) {
throw new AssertionError(e);
} catch (IOException e) {
throw new AssertionError(e);
} catch (Exception e) {
throw new AssertionError(e);
} finally {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public class SimpleXMLConverterTest {
private final Converter converter = initConverter();

private static Converter initConverter() {

Format format = new Format(0, null, new HyphenStyle(), Verbosity.HIGH);
Persister persister = new Persister(format);
return new SimpleXMLConverter(persister);
Expand Down

0 comments on commit 6eb605e

Please sign in to comment.