Reload zk cache asynchronously (apache#5049)

yciabaud · Aug 27, 2019 · d22e014 · d22e014
1 parent 40d6248
commit d22e014
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZooKeeperDataCache.java b/pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZooKeeperDataCache.java
@@ -112,12 +112,12 @@ public void invalidate(final String path) {
 
     @Override
     public void reloadCache(final String path) {
-        try {
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Reloading ZooKeeperDataCache at path {}", path);
-            }
-            cache.invalidate(path);
-            Optional<Entry<T, Stat>> cacheEntry = cache.getData(path, this, this);
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Reloading ZooKeeperDataCache at path {}", path);
+        }
+        cache.invalidate(path);
+
+        cache.getDataAsync(path, this, this).thenAccept(cacheEntry -> {
             if (!cacheEntry.isPresent()) {
                 if (LOG.isDebugEnabled()) {
                     LOG.debug("Node [{}] does not exist", path);
@@ -134,9 +134,10 @@ public void reloadCache(final String path) {
                     LOG.debug("Notified listener {} at path {}", listener, path);
                 }
             }
-        } catch (Exception e) {
-            LOG.warn("Reloading ZooKeeperDataCache failed at path: {}", path, e);
-        }
+        }).exceptionally(ex -> {
+            LOG.warn("Reloading ZooKeeperDataCache failed at path: {}", path, ex);
+            return null;
+        });
     }
 
     @Override