Skip to content

Commit

Permalink
Issue apache#2890: Dependencies for using Pulsar in Storm topologies (a…
Browse files Browse the repository at this point in the history
…pache#2893)

* Issue apache#2890: Dependencies for using Pulsar in Storm topologies

*Motivation*

Fixes apache#2890

The shading plugin used in pulsar-storm is promoting transitive dependencies
to the dependency-reduced pom, which will mix pulsar-client and pulsar-client-original
together in the classpath.

*Changes*

- disabled `promoteTransitiveDependencies` in pulsar-storm
- remove shade plugin from pulsar-flink

* don't exclude original, since pulsar-client pom will reduce the dependencies
  • Loading branch information
sijie authored and merlimat committed Oct 31, 2018
1 parent 2591ccd commit e72ed35
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 30 deletions.
29 changes: 0 additions & 29 deletions pulsar-flink/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -104,34 +104,5 @@
<filtering>true</filtering>
</resource>
</resources>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<artifactSet>
<includes>
<include>com.google.guava:guava</include>
</includes>
</artifactSet>
<relocations>
<relocation>
<pattern>com.google</pattern>
<shadedPattern>pulsar-flink-shade.com.google</shadedPattern>
</relocation>
</relocations>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
2 changes: 1 addition & 1 deletion pulsar-storm/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<promoteTransitiveDependencies>false</promoteTransitiveDependencies>
<artifactSet>
<includes>
<include>com.google.guava:guava</include>
Expand Down

0 comments on commit e72ed35

Please sign in to comment.