Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test connecting with jdk from ibm #380

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

ekuvardin
Copy link
Contributor

Faces some strange behavior with build on jdk from IBM any version(failed test on cast exception) and finally catch the issue

Take a look at class ClassCastException from IBM

	ClassCastException(Class instanceClass, Class castClass) {
		// K0340 = {0} incompatible with {1}
		super(com.ibm.oti.util.Msg.getString("K0340", instanceClass.getName(), castClass.getName())); //$NON-NLS-1$
	}

When JDK ClassCastException has one

 public ClassCastException(String s) {
        super(s);
    }

Running test on ibm semeru any version I got failed test, cause ClassCastException has text
incompatible with

OpenJDK/Azul Zing/Azul Zulu/Amazon Corretoo
cannot be cast

So one of the option it's add one more text description to test. May be better option it's just remove text connected to cast/incompatible? Just open to discussion.

Tested on Windows10/Ubuntu 24.04.01
OpenJdk 11, 21
IBM Semeru 21
AmazonCorreto 21

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.77%. Comparing base (c831264) to head (367aaf5).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #380      +/-   ##
============================================
+ Coverage     58.75%   58.77%   +0.01%     
  Complexity     2167     2167              
============================================
  Files           320      320              
  Lines         12894    12894              
  Branches       1265     1265              
============================================
+ Hits           7576     7578       +2     
+ Misses         4707     4705       -2     
  Partials        611      611              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 merged commit 0d08299 into ydb-platform:master Mar 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants