Merge pull request iterative#2011 from mroutis/refactor

refactor: rely on RemoteBasic._changed_dir_cache

dvc/remote/base.py

@@ -524,14 +524,7 @@ def changed_cache_file(self, checksum):
 
         return True
 
-    def _changed_cache_dir(self):
-        # NOTE: only implemented for RemoteLOCAL
-        return True
-
     def _changed_dir_cache(self, checksum):
-        if not self._changed_cache_dir():
-            return False
-
         if self.changed_cache_file(checksum):
             return True
 

dvc/remote/local/__init__.py

@@ -495,7 +495,7 @@ def pull(self, checksum_infos, remote, jobs=None, show_checksums=False):
             download=True,
         )
 
-    def _changed_cache_dir(self):
+    def _changed_dir_cache(self, checksum):
         mtime, size = get_mtime_and_size(self.cache_dir)
         inode = get_inode(self.cache_dir)
 
@@ -506,7 +506,10 @@ def _changed_cache_dir(self):
         else:
             changed = True
 
-        return changed
+        if not changed:
+            return False
+
+        return super(RemoteLOCAL, self)._changed_dir_cache(checksum)
 
     def _log_missing_caches(self, checksum_info_dict):
         missing_caches = [