Skip to content

Commit

Permalink
dts/bindings: Remove 'generate: define' from 'interrupt-names' bindings
Browse files Browse the repository at this point in the history
After commit 'scripts/dts: Never ignore properties in
generate_node_defines()', pointless entries for 'interrupt-names'
properties show up in generated_dts_board.conf and
generated_dts_board_fixups.h, because many bindings specify
'generate: define' for 'interrupt-names'.

If 'generation: define' is taken as "generate #define's for this
particular property", then only the 'interrupts' property ought to have
'generation: define'. Having it on both 'interrupts' and
'interrupt-names' makes you wonder what it would mean to only have it on
one of them.

Things get a bit confusing since 'interrupt-names' is still used when
determining the macro names generated for 'interrupts', but it's
probably best to have 'generation: define' work in a consistent way
still (and never be a no-op).

Remove 'generation: define' from all 'interrupt-names' bindings.

Signed-off-by: Ulf Magnusson <[email protected]>
  • Loading branch information
ulfalizer authored and galak committed Feb 27, 2019
1 parent 246a15c commit 3513c26
Show file tree
Hide file tree
Showing 17 changed files with 0 additions and 17 deletions.
1 change: 0 additions & 1 deletion dts/bindings/can/st,stm32-can.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ properties:
type: array
category: optional
description: names off the interrupt lines
generation: define

gpio-port:
type: string
Expand Down
1 change: 0 additions & 1 deletion dts/bindings/crypto/arm,cryptocell-310.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,3 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define
1 change: 0 additions & 1 deletion dts/bindings/flash_controller/flash-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,5 @@ properties:
type: stringlist
category: optional
description: names of required interrupts
generation: define

...
1 change: 0 additions & 1 deletion dts/bindings/i2c/intel,qmsi-ss-i2c.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

...
1 change: 0 additions & 1 deletion dts/bindings/i2c/st,stm32-i2c-v1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,4 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define
...
1 change: 0 additions & 1 deletion dts/bindings/i2c/st,stm32-i2c-v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,4 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define
...
1 change: 0 additions & 1 deletion dts/bindings/i2s/st,stm32-i2s.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

...
1 change: 0 additions & 1 deletion dts/bindings/rtc/rtc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ properties:
type: stringlist
category: optional
description: names of required interrupts
generation: define
prescaler:
type: int
category: required
Expand Down
1 change: 0 additions & 1 deletion dts/bindings/serial/uart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ properties:
type: stringlist
category: optional
description: names of required interrupts
generation: define
pinctrl-\d+:
type: array
category: optional
Expand Down
1 change: 0 additions & 1 deletion dts/bindings/spi/st,stm32-spi-fifo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,5 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

...
1 change: 0 additions & 1 deletion dts/bindings/spi/st,stm32-spi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

...
1 change: 0 additions & 1 deletion dts/bindings/usb/nordic,nrf-usbd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

num-isoin-endpoints:
type: int
Expand Down
1 change: 0 additions & 1 deletion dts/bindings/usb/nxp,kinetis-usbd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,4 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define
...
1 change: 0 additions & 1 deletion dts/bindings/usb/st,stm32-otgfs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

ram-size:
type: int
Expand Down
1 change: 0 additions & 1 deletion dts/bindings/usb/st,stm32-otghs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

ram-size:
type: int
Expand Down
1 change: 0 additions & 1 deletion dts/bindings/usb/st,stm32-usb.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

ram-size:
type: int
Expand Down
1 change: 0 additions & 1 deletion dts/bindings/watchdog/nordic,nrf-watchdog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,3 @@ properties:
type: stringlist
category: optional
description: readable string describing the interrupts
generation: define

0 comments on commit 3513c26

Please sign in to comment.