Skip to content

Commit

Permalink
Address Coverity issues.
Browse files Browse the repository at this point in the history
This patch addresses the use of uninitialised data raised in Coverity
issues 1414881 and 1414882.

Reviewed-by: Andy Polyakov <[email protected]>
(Merged from openssl#3929)
  • Loading branch information
paulidale committed Jul 16, 2017
1 parent d212b98 commit 20e237c
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions test/handshake_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -1319,6 +1319,8 @@ static HANDSHAKE_RESULT *do_handshake_internal(
memset(&client_ctx_data, 0, sizeof(client_ctx_data));
memset(&server, 0, sizeof(server));
memset(&client, 0, sizeof(client));
memset(&server_ex_data, 0, sizeof(server_ex_data));
memset(&client_ex_data, 0, sizeof(client_ex_data));

if (!configure_handshake_ctx(server_ctx, server2_ctx, client_ctx,
test_ctx, extra, &server_ctx_data,
Expand Down Expand Up @@ -1348,9 +1350,6 @@ static HANDSHAKE_RESULT *do_handshake_internal(
goto err;
}

memset(&server_ex_data, 0, sizeof(server_ex_data));
memset(&client_ex_data, 0, sizeof(client_ex_data));

ret->result = SSL_TEST_INTERNAL_ERROR;

if (test_ctx->use_sctp) {
Expand Down

0 comments on commit 20e237c

Please sign in to comment.