Skip to content

Commit

Permalink
feat: build missing architectures on iOS (facebook#363)
Browse files Browse the repository at this point in the history
Summary:
Turns out we need one more architecture for certain simulators (required by Xcode) to ship with the framework.

Pull Request resolved: facebook#363

Reviewed By: tmikov

Differential Revision: D23817621

Pulled By: dulinriley

fbshipit-source-id: 447aa3bc9a0cccced21462d5ba6cd2953464107c
  • Loading branch information
grabbou authored and facebook-github-bot committed Sep 22, 2020
1 parent 070ffdd commit cda1b53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hermes.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Pod::Spec.new do |spec|
# If universal framework for iOS does not exist, build one
if [ ! -d destroot/Library/Frameworks/iphoneos/hermes.framework ]; then
build_apple_framework "iphoneos" "armv7;armv7s;arm64" "#{HermesHelper::IOS_DEPLOYMENT_TARGET}"
build_apple_framework "iphonesimulator" "x86_64" "#{HermesHelper::IOS_DEPLOYMENT_TARGET}"
build_apple_framework "iphonesimulator" "x86_64;i386" "#{HermesHelper::IOS_DEPLOYMENT_TARGET}"
create_universal_framework "iphoneos" "iphonesimulator"
fi
Expand Down

0 comments on commit cda1b53

Please sign in to comment.