Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: liquity adjust #296

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

integration: liquity adjust #296

wants to merge 9 commits into from

Conversation

marcomariscal
Copy link
Contributor

@marcomariscal marcomariscal commented Jun 26, 2023

Description

Allows for adjusting a liquity trove. Requires knowledge of how to adjust a trove and prerequisite understanding of the action's corresponding prompt structure. Will have to think more about this.

Todo (moreso things to think about cuz probably not implementing just yet because of the level of complexity)

  • Think about how to handle one project "action" (adjust in this case) that allows for many inputs (repay amount, withdraw amount, etc.)
  • Handle errors (if the adjustment can't be deduced, or if the resulting adjustment would lead to an undercollateralized trove, etc.)
  • Handle getting data; i dont easily know how much debt/collateral is in my trove
  • Potentially stricter prop types for generalized/templated components (I don't know what to pass into SingleLineResponse or DoubleLineResponse)
  • Create a generic getPrice function to be able to calculate the collateralization ratio

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for ironclad-parent ready!

Name Link
🔨 Latest commit 2027252
🔍 Latest deploy log https://app.netlify.com/sites/ironclad-parent/deploys/649c033a1f9e290008d61ca0
😎 Deploy Preview https://deploy-preview-296--ironclad-parent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcomariscal marcomariscal marked this pull request as ready for review June 27, 2023 17:52
@marcomariscal marcomariscal changed the title feat: liquity adjust integration: liquity adjust Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants