Skip to content

Commit

Permalink
Add support for --ssl-no-revoke (jfrog#48)
Browse files Browse the repository at this point in the history
* Add support for --ssl-no-revoke

* Update README.md

Update docs to new parameter COCOAPODS_ART_SSL_NO_REOVKE

* Update cocoapods_plugin.rb

Fix env name typo

* Update README.md

Fix typo in env name
  • Loading branch information
shayfisher authored Jul 20, 2021
1 parent 0a510c5 commit a56be15
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ If your .netrc file is not located in your home directory, you can specify its l
export COCOAPODS_ART_NETRC_PATH=$HOME/myproject/.netrc
```

You could set the following environment variable: COCOAPODS_ART_SSL_NO_REVOKE, this will add the flag --ssl-no-revoke to curl command.
If your are running on an environment where access to CRL isn't available you would still be able to access Artifactory via HTTPS using the cocoapods-art plugin on windows.
```
set COCOAPODS_ART_SSL_NO_REVOKE=true
```

## Artifactory Configuration
See the [Artifactory User Guide](https://www.jfrog.com/confluence/display/RTF/CocoaPods+Repositories)

Expand Down
5 changes: 4 additions & 1 deletion lib/cocoapods_plugin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ def download_file(full_filename)
netrc_path = ENV["COCOAPODS_ART_NETRC_PATH"]
parameters.concat(["--netrc-file", Pathname.new(netrc_path).expand_path]) if netrc_path

winssl_no_revoke = ENV["COCOAPODS_ART_SSL_NO_REVOKE"]
parameters.concat(["--ssl-no-revoke"]) if defined? winssl_no_revoke && "true".casecmp(winssl_no_revoke)

headers.each do |h|
parameters << '-H'
parameters << h
Expand Down Expand Up @@ -145,4 +148,4 @@ def source_from_path(path)

end
end
end
end

0 comments on commit a56be15

Please sign in to comment.