Skip to content

Commit

Permalink
misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()
Browse files Browse the repository at this point in the history
This code was using get_user_pages*(), in approximately a "Case 1"
scenario (Direct IO), using the categorization from [1]. That means
that it's time to convert the get_user_pages*() + put_page() calls to
pin_user_pages*() + unpin_user_pages() calls.

There is some helpful background in [2]: basically, this is a small
part of fixing a long-standing disconnect between pinning pages, and
file systems' use of those pages.

[1] Documentation/core-api/pin_user_pages.rst

[2] "Explicit pinning of user-space pages":
    https://lwn.net/Articles/807108/

Cc: Derek Kiernan <[email protected]>
Cc: Dragan Cvetic <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: [email protected]
Signed-off-by: John Hubbard <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
johnhubbard authored and gregkh committed May 27, 2020
1 parent d25594d commit 03358b0
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/misc/xilinx_sdfec.c
Original file line number Diff line number Diff line change
Expand Up @@ -627,12 +627,11 @@ static int xsdfec_table_write(struct xsdfec_dev *xsdfec, u32 offset,

nr_pages = n;

res = get_user_pages_fast((unsigned long)src_ptr, nr_pages, 0, pages);
res = pin_user_pages_fast((unsigned long)src_ptr, nr_pages, 0, pages);
if (res < nr_pages) {
if (res > 0) {
for (i = 0; i < res; i++)
put_page(pages[i]);
}
if (res > 0)
unpin_user_pages(pages, res);

return -EINVAL;
}

Expand All @@ -646,7 +645,7 @@ static int xsdfec_table_write(struct xsdfec_dev *xsdfec, u32 offset,
reg++;
} while ((reg < len) &&
((reg * XSDFEC_REG_WIDTH_JUMP) % PAGE_SIZE));
put_page(pages[i]);
unpin_user_page(pages[i]);
}
return 0;
}
Expand Down

0 comments on commit 03358b0

Please sign in to comment.