plugins can get vConsole by this.vConsole after init event

yk007 · Sep 21, 2017 · 370b835 · 370b835
1 parent d8457ff
commit 370b835
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/core/core.js b/src/core/core.js
@@ -403,7 +403,7 @@ class VConsole {
    */
   _initPlugin(plugin) {
     let that = this;
-    plugin.setVConsole(this);
+    plugin.vConsole = this;
     // start init
     plugin.trigger('init');
     // render tab (if it is a tab plugin then it should has tab-related events)

diff --git a/src/lib/plugin.js b/src/lib/plugin.js
@@ -18,7 +18,6 @@ class VConsolePlugin {
   constructor(id, name = 'newPlugin') {
     this.id = id;
     this.name = name;
-    this.vConsole = null;
 
     this.eventList = {};
   }
@@ -43,8 +42,14 @@ class VConsolePlugin {
     this._name = value;
   }
 
-  setVConsole(obj) {
-    this.vConsole = obj;
+  get vConsole() {
+    return this._vConsole || undefined;
+  }
+  set vConsole(value) {
+    if (!value) {
+      throw 'vConsole cannot be empty';
+    }
+    this._vConsole = value;
   }
 
   /**