Skip to content

Commit

Permalink
Add support for different encoder pinout for right half of split keyb…
Browse files Browse the repository at this point in the history
…oard (qmk#6521)

* Add support for different encoder pinouts for split keyboard

* Update documentation for new encoder pinout feature
  • Loading branch information
nooges authored and drashna committed Aug 16, 2019
1 parent 61b5914 commit 36dd261
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 0 deletions.
9 changes: 9 additions & 0 deletions docs/feature_encoders.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ Additionally, the resolution can be specified in the same file (the default & su

#define ENCODER_RESOLUTION 4

## Split Keyboards

If you are using different pinouts for the encoders on each half of a split keyboard, you can define the pinout for the right half like this:

```c
#define ENCODERS_PAD_A_RIGHT { encoder1a, encoder2a }
#define ENCODERS_PAD_B_RIGHT { encoder1b, encoder2b }
```
## Callbacks
The callback functions can be inserted into your `<keyboard>.c`:
Expand Down
7 changes: 7 additions & 0 deletions docs/feature_split_keyboard.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ This allows you to specify a different set of pins for the matrix on the right s
This allows you to specify a different set of direct pins for the right side.
```c
#define ENCODERS_PAD_A_RIGHT { encoder1a, encoder2a }
#define ENCODERS_PAD_B_RIGHT { encoder1b, encoder2b }
```

This allows you to specify a different set of encoder pins for the right side.

```c
#define RGBLIGHT_SPLIT
```
Expand Down
14 changes: 14 additions & 0 deletions quantum/encoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
*/

#include "encoder.h"
#ifdef SPLIT_KEYBOARD
#include "split_util.h"
#endif

// for memcpy
#include <string.h>
Expand Down Expand Up @@ -54,6 +57,17 @@ void encoder_update_kb(int8_t index, bool clockwise) {
}

void encoder_init(void) {
#if defined(SPLIT_KEYBOARD) && defined(ENCODERS_PAD_A_RIGHT) && defined(ENCODERS_PAD_B_RIGHT)
if (!isLeftHand) {
const pin_t encoders_pad_a_right[] = ENCODERS_PAD_A_RIGHT;
const pin_t encoders_pad_b_right[] = ENCODERS_PAD_B_RIGHT;
for (uint8_t i = 0; i < NUMBER_OF_ENCODERS; i++) {
encoders_pad_a[i] = encoders_pad_a_right[i];
encoders_pad_b[i] = encoders_pad_b_right[i];
}
}
#endif

for (int i = 0; i < NUMBER_OF_ENCODERS; i++) {
setPinInputHigh(encoders_pad_a[i]);
setPinInputHigh(encoders_pad_b[i]);
Expand Down

0 comments on commit 36dd261

Please sign in to comment.