Return failed authorization when doing a SkipJack purchase

yob · Nov 27, 2008 · b146245 · b146245
1 parent 596495b
commit b146245
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,7 +1,8 @@
 = ActiveMerchant CHANGELOG
 
-== Version 1.4.0 (November 25, 2008)
+== Version 1.4.0 (November 27, 2008)
 
+* Return failed authorization when SkipJack purchase fails [Tron, cody]
 * Update README [cody]
 * Add metadata to Authorize.net CIM gateway [cody]
 * Make ActionViewHelper compatible with changes to concat method in ActionPack [cody]

diff --git a/lib/active_merchant/billing/gateways/skip_jack.rb b/lib/active_merchant/billing/gateways/skip_jack.rb
@@ -195,6 +195,8 @@ def purchase(money, creditcard, options = {})
         authorization = authorize(money, creditcard, options)
         if authorization.success?
           capture(money, authorization.authorization)
+        else
+          authorization
         end
       end
 

diff --git a/test/unit/gateways/skip_jack_test.rb b/test/unit/gateways/skip_jack_test.rb
@@ -62,6 +62,14 @@ def test_purchase_success
     assert_success response
     assert_equal "9802853155172.022", response.authorization
   end
+
+  def test_purchase_failure
+    @gateway.expects(:ssl_post).returns(unsuccessful_authorization_response)
+
+    assert response = @gateway.purchase(@amount, @credit_card, @options)
+    assert_instance_of Response, response
+    assert_failure response
+  end
 
   def test_split_line
     keys = @gateway.send(:split_line, '"AUTHCODE","szSerialNumber","szTransactionAmount","szAuthorizationDeclinedMessage","szAVSResponseCode","szAVSResponseMessage","szOrderNumber","szAuthorizationResponseCode","szIsApproved","szCVV2ResponseCode","szCVV2ResponseMessage","szReturnCode","szTransactionFileName","szCAVVResponseCode"')