Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if now Hound is well tamed 🐶 #80

Closed
wants to merge 1 commit into from

Conversation

5t111111
Copy link
Collaborator

@5t111111 5t111111 commented Sep 6, 2016

手元の実行結果

🐳  ~/.ghq/git/yoc/kawaiichan on check-if-hound-is-well-tamed ⨯ rubocop
Inspecting 72 files
.....CC...........................................................C.....

Offenses:

app/channels/post_channel.rb:1:121: C: Line is too long. [125/120]
# Be sure to restart your server when you modify this file. Action Cable runs in a loop that does not support auto reloading.
                                                                                                                        ^^^^^
app/controllers/application_controller.rb:9:3: C: Avoid single-line method definitions.
  def kawaiichan; puts "🌚"; end
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
test/helpers/emoji_helper_test.rb:5:121: C: Line is too long. [279/120]
    assert_equal %(Hello <img alt="new_moon_with_face" src="/images/emoji/unicode/1f31a.png" style="vertical-align:middle" width="20" height="20" />, good-bye <img alt="sun_with_face" src="/images/emoji/unicode/1f31e.png" style="vertical-align:middle" width="20" height="20" />),
                                                                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Hound の設定

Style/SingleLineMethods:
  Description: Avoid single-line methods.
  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-single-line-methods
  Enabled: false
  AllowIfMethodIsEmpty: true

@@ -6,6 +6,8 @@ class ApplicationController < ActionController::Base
before_action :set_paper_trail_whodunnit
helper_method :current_user, :logged_in?

def kawaiichan; puts "🌚"; end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid single-line method definitions.

@5t111111
Copy link
Collaborator Author

5t111111 commented Sep 6, 2016

期待通りっぽいですね。確認してもらえたら閉じちゃってください。

@yucao24hours
Copy link
Member

ありがとうございます ❗❗❗❗❗ 🐶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants