Skip to content

Commit

Permalink
Fix help-dialog links.
Browse files Browse the repository at this point in the history
It's not clear when -- possibly when we moved the help dialog to an
iframe -- the links at the bottom of the help dialog stopped working.

Here, we reinstate them by opening the referenced page in a new tab.
This is consistent with the behaviour of the links at the top of the
help dialog.

Also, the "please review us" link now points to the "reviews" tab on the
Chrome store.
  • Loading branch information
smblott-github committed Apr 22, 2016
1 parent c279d9a commit b353233
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions pages/help_dialog.html
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,14 @@

<div class="vimiumReset vimiumColumn">
Enjoying Vimium?
<a class="vimiumReset" href="https://chrome.google.com/extensions/detail/dbepggeogbaibhgnhhndojpepiihcmeb">Leave us
<a class="vimiumReset" target="_blank"
href="https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb/reviews">Leave us
feedback</a>.<br/>
Found a bug? <a class="vimiumReset" href="http://github.com/philc/vimium/issues">Report it here</a>.
Found a bug? <a class="vimiumReset" target="_blank" href="http://github.com/philc/vimium/issues">Report it here</a>.
</div>
<div class="vimiumReset vimiumColumn" style="text-align:right">
<span class="vimiumReset">Version <span id="help-dialog-version"></span></span><br/>
<a href="https://github.com/philc/vimium#release-notes" class="vimiumReset">What's new?</a>
<a target="_blank" href="https://github.com/philc/vimium#release-notes" class="vimiumReset">What's new?</a>
</div>
</div>
</div>
Expand Down

0 comments on commit b353233

Please sign in to comment.