MDL-60139 phpunit: Make assertTag verify attribute values with ===

I had a test that cared about the difference between value="5.0" and value="5".
yousuftafhim · Oct 30, 2017 · 46a3753 · 46a3753
1 parent 40f1801
commit 46a3753
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/phpunit/classes/base_testcase.php b/lib/phpunit/classes/base_testcase.php
@@ -242,7 +242,7 @@ public static function findNodes(DOMDocument $dom, array $options, $isHtml = tru
                         }
                     } // match by exact string
                     else {
-                        if ($node->getAttribute($name) != $value) {
+                        if ($node->getAttribute($name) !== (string) $value) {
                             $invalid = true;
                         }
                     }