MDL-56893 grades: Fix edit grade item when grade_report_showmin is false

Check to make sure $data['grademin'] exists. When grade_report_showmin is false $data['grademin'] doesn't exist.
yousuftafhim · Nov 30, 2016 · d27e1c7 · d27e1c7
1 parent 258d07d
commit d27e1c7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/grade/edit/tree/item_form.php b/grade/edit/tree/item_form.php
@@ -463,7 +463,8 @@ function validation($data, $files) {
         }
         if ($grade_item) {
             if ($grade_item->gradetype == GRADE_TYPE_VALUE) {
-                if (grade_floats_different($data['grademin'], $grade_item->grademin) ||
+                if ((((bool) get_config('moodle', 'grade_report_showmin')) &&
+                    grade_floats_different($data['grademin'], $grade_item->grademin)) ||
                     grade_floats_different($data['grademax'], $grade_item->grademax)) {
                     if ($grade_item->has_grades() && empty($data['rescalegrades'])) {
                         $errors['rescalegrades'] = get_string('mustchooserescaleyesorno', 'grades');