gradebook MDL-25713 now closing the recordset even when theres a problem

yousuftafhim · Dec 23, 2010 · fc61acc · fc61acc
1 parent 2f9ea7d
commit fc61acc
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/grade/grade_object.php b/lib/grade/grade_object.php
@@ -187,7 +187,8 @@ public static function fetch_all_helper($table, $classname, $params) {
         $rs = $DB->get_recordset_select($table, $wheresql, $newparams);
         //returning false rather than empty array if nothing found
         if (!$rs->valid()) {
-             return false;
+            $rs->close();
+            return false;
         }
 
         $result = array();