Skip to content

Commit

Permalink
ide: remove ide_init_default_irq() macro
Browse files Browse the repository at this point in the history
* Use ide_default_irq() instead of ide_init_default_irq() in
  ide_generic host driver (so the correct IRQ is always set
  regardless of CONFIG_PCI / CONFIG_BLK_DEV_IDEPCI).

* Remove no longer needed ide_init_default_irq() macro.

Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
  • Loading branch information
bzolnier committed Apr 17, 2008
1 parent 486c92e commit 273b838
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 37 deletions.
2 changes: 1 addition & 1 deletion drivers/ide/ide-generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ static int __init ide_generic_init(void)
if (hwif->chipset == ide_unknown && io_addr) {
memset(&hw, 0, sizeof(hw));
ide_std_init_ports(&hw, io_addr, io_addr + 0x206);
hw.irq = ide_init_default_irq(io_addr);
hw.irq = ide_default_irq(io_addr);
ide_init_port_hw(hwif, &hw);

idx[i] = i;
Expand Down
6 changes: 0 additions & 6 deletions include/asm-alpha/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,6 @@ static inline unsigned long ide_default_io_base(int index)
}
}

#ifdef CONFIG_PCI
#define ide_init_default_irq(base) (0)
#else
#define ide_init_default_irq(base) ide_default_irq(base)
#endif

#include <asm-generic/ide_iops.h>

#endif /* __KERNEL__ */
Expand Down
6 changes: 0 additions & 6 deletions include/asm-ia64/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ static inline unsigned long ide_default_io_base(int index)
}
}

#ifdef CONFIG_PCI
#define ide_init_default_irq(base) (0)
#else
#define ide_init_default_irq(base) ide_default_irq(base)
#endif

#include <asm-generic/ide_iops.h>

#endif /* __KERNEL__ */
Expand Down
6 changes: 0 additions & 6 deletions include/asm-m32r/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ static __inline__ unsigned long ide_default_io_base(int index)
}
}

#ifdef CONFIG_BLK_DEV_IDEPCI
#define ide_init_default_irq(base) (0)
#else
#define ide_init_default_irq(base) ide_default_irq(base)
#endif

#include <asm-generic/ide_iops.h>

#endif /* __KERNEL__ */
Expand Down
6 changes: 0 additions & 6 deletions include/asm-mips/mach-generic/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,6 @@ static __inline__ unsigned long ide_default_io_base(int index)
}
}

#ifdef CONFIG_BLK_DEV_IDEPCI
#define ide_init_default_irq(base) (0)
#else
#define ide_init_default_irq(base) ide_default_irq(base)
#endif

/* MIPS port and memory-mapped I/O string operations. */
static inline void __ide_flush_prologue(void)
{
Expand Down
6 changes: 0 additions & 6 deletions include/asm-powerpc/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,6 @@ static __inline__ unsigned long ide_default_io_base(int index)
return 0;
}

#ifdef CONFIG_PCI
#define ide_init_default_irq(base) (0)
#else
#define ide_init_default_irq(base) ide_default_irq(base)
#endif

#ifdef CONFIG_BLK_DEV_MPC8xx_IDE
#define IDE_ARCH_ACK_INTR 1
#define ide_ack_intr(hwif) ((hwif)->ack_intr ? (hwif)->ack_intr(hwif) : 1)
Expand Down
6 changes: 0 additions & 6 deletions include/asm-x86/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,6 @@ static __inline__ unsigned long ide_default_io_base(int index)
}
}

#ifdef CONFIG_BLK_DEV_IDEPCI
#define ide_init_default_irq(base) (0)
#else
#define ide_init_default_irq(base) ide_default_irq(base)
#endif

#include <asm-generic/ide_iops.h>

#endif /* __KERNEL__ */
Expand Down

0 comments on commit 273b838

Please sign in to comment.