Skip to content

Commit

Permalink
ktest: Fix bug where the test would not end after failure
Browse files Browse the repository at this point in the history
The config STOP_AFTER_FAILURE is the number of seconds to continue
the test when a failure is detected. This lets the monitor record
more data to the logs and console that may be helpful in solving
the bug that was found.

But the test had a bug. If the failure caused multiple
"Call Trace" stack dumps, the start time to compare the
STOP_AFTER_FAILURE would constantly be reset. Only update the start
time at the first "Call Trace" instance.

Signed-off-by: Steven Rostedt <[email protected]>
  • Loading branch information
Steven Rostedt authored and rostedt committed Mar 8, 2011
1 parent 3410f6f commit 4651920
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/ktest/ktest.pl
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ sub monitor {
}

if ($full_line =~ /call trace:/i) {
if (!$skip_call_trace) {
if (!$bug && !$skip_call_trace) {
$bug = 1;
$failure_start = time;
}
Expand Down

0 comments on commit 4651920

Please sign in to comment.