Skip to content

Commit

Permalink
kernel/printk: do not turn off bootconsole in printk_late_init() if k…
Browse files Browse the repository at this point in the history
…eep_bootcon

It seems that 7bf6939 ("console: allow to retain boot console via
boot option keep_bootcon") doesn't always achieve what it aims, as when
printk_late_init() runs it unconditionally turns off all boot consoles.
With this patch, I am able to see more messages on the boot console in
KVM guests than I can without, when keep_bootcon is specified.

I think it is appropriate for the relevant -stable trees.  However, it's
more of an annoyance than a serious bug (ideally you don't need to keep
the boot console around as console handover should be working -- I was
encountering a situation where the console handover wasn't working and
not having the boot console available meant I couldn't see why).

Signed-off-by: Nishanth Aravamudan <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Alan Cox <[email protected]>
Cc: Greg KH <[email protected]>
Acked-by: Fabio M. Di Nitto <[email protected]>
Cc: <[email protected]>		[2.6.39.x, 3.0.x]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Nishanth Aravamudan authored and torvalds committed Aug 25, 2011
1 parent 4733123 commit 4c30c6f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/printk.c
Original file line number Diff line number Diff line change
Expand Up @@ -1604,7 +1604,7 @@ static int __init printk_late_init(void)
struct console *con;

for_each_console(con) {
if (con->flags & CON_BOOT) {
if (!keep_bootcon && con->flags & CON_BOOT) {
printk(KERN_INFO "turn off boot console %s%d\n",
con->name, con->index);
unregister_console(con);
Expand Down

0 comments on commit 4c30c6f

Please sign in to comment.