Skip to content

Commit

Permalink
kbuild: whitelist logo references from .text to .init.data
Browse files Browse the repository at this point in the history
drivers/video/logo has references from .text to .init.data
but function is only used during early init.
So reference is OK and we do not want to warn about them =>
whitelist the reference.

Signed-off-by: Sam Ravnborg <[email protected]>
  • Loading branch information
sravnborg committed May 2, 2007
1 parent a61b2df commit 5a4910f
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions scripts/mod/modpost.c
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,15 @@ static int strrcmp(const char *s, const char *sub)
* fromsec = .text
* atsym = kernel_init
* Some symbols belong to init section but still it is ok to reference
*
* Pattern 7:
* Logos used in drivers/video/logo reside in __initdata but the
* funtion that references them are EXPORT_SYMBOL() so cannot be
* marker __init. So we whitelist them here.
* The pattern is:
* tosec = .init.data
* fromsec = .text*
* refsymname = logo_
**/
static int secref_whitelist(const char *modname, const char *tosec,
const char *fromsec, const char *atsym,
Expand Down Expand Up @@ -687,6 +696,12 @@ static int secref_whitelist(const char *modname, const char *tosec,
(strcmp(fromsec, ".text") == 0) &&
(strcmp(refsymname, "kernel_init") == 0))
return 1;

/* Check for pattern 7 */
if ((strcmp(tosec, ".init.data") == 0) &&
(strncmp(fromsec, ".text", strlen(".text")) == 0) &&
(strncmp(refsymname, "logo_", strlen("logo_")) == 0))
return 1;
return 0;
}

Expand Down

0 comments on commit 5a4910f

Please sign in to comment.