Skip to content

Commit

Permalink
vfs: Rename fsync_super() to sync_filesystem() (version 4)
Browse files Browse the repository at this point in the history
Rename the function so that it better describe what it really does. Also
remove the unnecessary include of buffer_head.h.

Signed-off-by: Jan Kara <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
jankara authored and Al Viro committed Jun 12, 2009
1 parent c15c54f commit 60b0680
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 13 deletions.
4 changes: 2 additions & 2 deletions fs/block_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ int fsync_bdev(struct block_device *bdev)
{
struct super_block *sb = get_super(bdev);
if (sb) {
int res = fsync_super(sb);
int res = sync_filesystem(sb);
drop_super(sb);
return res;
}
Expand Down Expand Up @@ -246,7 +246,7 @@ struct super_block *freeze_bdev(struct block_device *bdev)
sb->s_frozen = SB_FREEZE_WRITE;
smp_wmb();

fsync_super(sb);
sync_filesystem(sb);

sb->s_frozen = SB_FREEZE_TRANS;
smp_wmb();
Expand Down
2 changes: 1 addition & 1 deletion fs/cachefiles/interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ static void cachefiles_sync_cache(struct fscache_cache *_cache)
/* make sure all pages pinned by operations on behalf of the netfs are
* written to disc */
cachefiles_begin_secure(cache, &saved_cred);
ret = fsync_super(cache->mnt->mnt_sb);
ret = sync_filesystem(cache->mnt->mnt_sb);
cachefiles_end_secure(cache, saved_cred);

if (ret == -EIO)
Expand Down
5 changes: 2 additions & 3 deletions fs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include <linux/blkdev.h>
#include <linux/quotaops.h>
#include <linux/namei.h>
#include <linux/buffer_head.h> /* for fsync_super() */
#include <linux/mount.h>
#include <linux/security.h>
#include <linux/syscalls.h>
Expand Down Expand Up @@ -304,7 +303,7 @@ void generic_shutdown_super(struct super_block *sb)

if (sb->s_root) {
shrink_dcache_for_umount(sb);
fsync_super(sb);
sync_filesystem(sb);
lock_super(sb);
sb->s_flags &= ~MS_ACTIVE;

Expand Down Expand Up @@ -543,7 +542,7 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force)
if (flags & MS_RDONLY)
acct_auto_close(sb);
shrink_dcache_sb(sb);
fsync_super(sb);
sync_filesystem(sb);

/* If we are remounting RDONLY and current sb is read/write,
make sure there are no rw files opened */
Expand Down
12 changes: 6 additions & 6 deletions fs/sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
* case write_inode() functions do sync_dirty_buffer() and thus effectively
* write one block at a time.
*/
static int __fsync_super(struct super_block *sb, int wait)
static int __sync_filesystem(struct super_block *sb, int wait)
{
vfs_dq_sync(sb);
sync_inodes_sb(sb, wait);
Expand All @@ -43,16 +43,16 @@ static int __fsync_super(struct super_block *sb, int wait)
* superblock. Filesystem data as well as the underlying block
* device. Takes the superblock lock.
*/
int fsync_super(struct super_block *sb)
int sync_filesystem(struct super_block *sb)
{
int ret;

ret = __fsync_super(sb, 0);
ret = __sync_filesystem(sb, 0);
if (ret < 0)
return ret;
return __fsync_super(sb, 1);
return __sync_filesystem(sb, 1);
}
EXPORT_SYMBOL_GPL(fsync_super);
EXPORT_SYMBOL_GPL(sync_filesystem);

/*
* Sync all the data for all the filesystems (called by sys_sync() and
Expand Down Expand Up @@ -92,7 +92,7 @@ static void sync_filesystems(int wait)
spin_unlock(&sb_lock);
down_read(&sb->s_umount);
if (sb->s_root)
__fsync_super(sb, wait);
__sync_filesystem(sb, wait);
up_read(&sb->s_umount);
/* restart only when sb is no longer on the list */
spin_lock(&sb_lock);
Expand Down
2 changes: 1 addition & 1 deletion include/linux/fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -1958,7 +1958,7 @@ static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb)
return 0;
}
#endif
extern int fsync_super(struct super_block *);
extern int sync_filesystem(struct super_block *);
extern const struct file_operations def_blk_fops;
extern const struct file_operations def_chr_fops;
extern const struct file_operations bad_sock_fops;
Expand Down

0 comments on commit 60b0680

Please sign in to comment.