Skip to content

Commit

Permalink
[MIPS] RB532: Flags are unsigned long
Browse files Browse the repository at this point in the history
A recent generic change now catches such bugs:

<--  snip  -->

...
  CC      arch/mips/rb532/time.o
cc1: warnings being treated as errors
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/rb532/time.c: In function 'plat_time_init':
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/rb532/time.c:55: error: comparison of distinct pointer types lacks a cast
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/rb532/time.c:66: error: comparison of distinct pointer types lacks a cast
make[2]: *** [arch/mips/rb532/time.o] Error 1

<--  snip  -->

Reported-by: Adrian Bunk <[email protected]>
Signed-off-by: Adrian Bunk <[email protected]>
Signed-off-by: Ralf Baechle <[email protected]>
  • Loading branch information
AdrianBunk authored and ralfbaechle committed Jul 30, 2008
1 parent fd7ccfa commit 8b32d6d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions arch/mips/rb532/gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ static struct resource rb532_dev3_ctl_res[] = {

void set_434_reg(unsigned reg_offs, unsigned bit, unsigned len, unsigned val)
{
unsigned flags, data;
unsigned long flags;
unsigned data;
unsigned i = 0;

spin_lock_irqsave(&dev3.lock, flags);
Expand All @@ -90,7 +91,7 @@ EXPORT_SYMBOL(get_434_reg);

void set_latch_u5(unsigned char or_mask, unsigned char nand_mask)
{
unsigned flags;
unsigned long flags;

spin_lock_irqsave(&dev3.lock, flags);

Expand Down
4 changes: 2 additions & 2 deletions arch/mips/rb532/time.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ static unsigned long __init cal_r4koff(void)

void __init plat_time_init(void)
{
unsigned int est_freq, flags;
unsigned long r4k_offset;
unsigned int est_freq;
unsigned long flags, r4k_offset;

local_irq_save(flags);

Expand Down

0 comments on commit 8b32d6d

Please sign in to comment.