Skip to content

Commit

Permalink
sound: serial-u16550: fix buffer overflow
Browse files Browse the repository at this point in the history
Remove most of the serial port parameters from the card longname string
because it was way too long and overflowed into the mixername string.

Signed-off-by: Clemens Ladisch <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
cladisch authored and tiwai committed May 5, 2009
1 parent 3f68165 commit bd0185c
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions sound/drivers/serial-u16550.c
Original file line number Diff line number Diff line change
Expand Up @@ -963,16 +963,11 @@ static int __devinit snd_serial_probe(struct platform_device *devptr)
if (err < 0)
goto _err;

sprintf(card->longname, "%s at 0x%lx, irq %d speed %d div %d outs %d ins %d adaptor %s droponfull %d",
sprintf(card->longname, "%s [%s] at %#lx, irq %d",
card->shortname,
uart->base,
uart->irq,
uart->speed,
(int)uart->divisor,
outs[dev],
ins[dev],
adaptor_names[uart->adaptor],
uart->drop_on_full);
uart->base,
uart->irq);

snd_card_set_dev(card, &devptr->dev);

Expand Down

0 comments on commit bd0185c

Please sign in to comment.