Skip to content

Commit

Permalink
Merge branch 'pm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/…
Browse files Browse the repository at this point in the history
…git/rafael/linux-pm

* 'pm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
  ARM: mach-shmobile: sh7372 LCDC1 suspend fix V2 (incremental)
  OMAP: omap_device: only override _noirq methods, not normal suspend/resume
  PM / Runtime: Correct documentation of pm_runtime_irq_safe()
  ARM: mach-shmobile: sh7372 LCDC1 suspend fix
  sh-sci / PM: Use power.irq_safe
  PM: Use spinlock instead of mutex in clock management functions
  • Loading branch information
torvalds committed Aug 28, 2011
2 parents 219f358 + d0168fd commit c11a7e2
Show file tree
Hide file tree
Showing 7 changed files with 30 additions and 21 deletions.
3 changes: 1 addition & 2 deletions Documentation/power/runtime_pm.txt
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,7 @@ drivers/base/power/runtime.c and include/linux/pm_runtime.h:

void pm_runtime_irq_safe(struct device *dev);
- set the power.irq_safe flag for the device, causing the runtime-PM
suspend and resume callbacks (but not the idle callback) to be invoked
with interrupts disabled
callbacks to be invoked with interrupts off

void pm_runtime_mark_last_busy(struct device *dev);
- set the power.last_busy field to the current time
Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-shmobile/board-ap4evb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,7 @@ static void __init ap4evb_init(void)
fsi_init_pm_clock();
sh7372_pm_init();
pm_clk_add(&fsi_device.dev, "spu2");
pm_clk_add(&lcdc1_device.dev, "hdmi");
}

static void __init ap4evb_timer_init(void)
Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-shmobile/board-mackerel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1588,6 +1588,7 @@ static void __init mackerel_init(void)
hdmi_init_pm_clock();
sh7372_pm_init();
pm_clk_add(&fsi_device.dev, "spu2");
pm_clk_add(&hdmi_lcdc_device.dev, "hdmi");
}

static void __init mackerel_timer_init(void)
Expand Down
2 changes: 2 additions & 0 deletions arch/arm/mach-shmobile/clock-sh7372.c
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,8 @@ static struct clk_lookup lookups[] = {
CLKDEV_DEV_ID("renesas_usbhs.1", &mstp_clks[MSTP406]), /* USB1 */
CLKDEV_DEV_ID("sh_keysc.0", &mstp_clks[MSTP403]), /* KEYSC */

CLKDEV_ICK_ID("hdmi", "sh_mobile_lcdc_fb.1",
&div6_reparent_clks[DIV6_HDMI]),
CLKDEV_ICK_ID("ick", "sh-mobile-hdmi", &div6_reparent_clks[DIV6_HDMI]),
CLKDEV_ICK_ID("icka", "sh_fsi2", &div6_reparent_clks[DIV6_FSIA]),
CLKDEV_ICK_ID("ickb", "sh_fsi2", &div6_reparent_clks[DIV6_FSIB]),
Expand Down
3 changes: 2 additions & 1 deletion arch/arm/plat-omap/omap_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,8 @@ static struct dev_pm_domain omap_device_pm_domain = {
SET_RUNTIME_PM_OPS(_od_runtime_suspend, _od_runtime_resume,
_od_runtime_idle)
USE_PLATFORM_PM_SLEEP_OPS
SET_SYSTEM_SLEEP_PM_OPS(_od_suspend_noirq, _od_resume_noirq)
.suspend_noirq = _od_suspend_noirq,
.resume_noirq = _od_resume_noirq,
}
};

Expand Down
40 changes: 22 additions & 18 deletions drivers/base/power/clock_ops.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

struct pm_clk_data {
struct list_head clock_list;
struct mutex lock;
spinlock_t lock;
};

enum pce_status {
Expand Down Expand Up @@ -73,18 +73,18 @@ int pm_clk_add(struct device *dev, const char *con_id)
}
}

mutex_lock(&pcd->lock);
spin_lock_irq(&pcd->lock);
list_add_tail(&ce->node, &pcd->clock_list);
mutex_unlock(&pcd->lock);
spin_unlock_irq(&pcd->lock);
return 0;
}

/**
* __pm_clk_remove - Destroy PM clock entry.
* @ce: PM clock entry to destroy.
*
* This routine must be called under the mutex protecting the PM list of clocks
* corresponding the the @ce's device.
* This routine must be called under the spinlock protecting the PM list of
* clocks corresponding the the @ce's device.
*/
static void __pm_clk_remove(struct pm_clock_entry *ce)
{
Expand Down Expand Up @@ -123,7 +123,7 @@ void pm_clk_remove(struct device *dev, const char *con_id)
if (!pcd)
return;

mutex_lock(&pcd->lock);
spin_lock_irq(&pcd->lock);

list_for_each_entry(ce, &pcd->clock_list, node) {
if (!con_id && !ce->con_id) {
Expand All @@ -137,7 +137,7 @@ void pm_clk_remove(struct device *dev, const char *con_id)
}
}

mutex_unlock(&pcd->lock);
spin_unlock_irq(&pcd->lock);
}

/**
Expand All @@ -158,7 +158,7 @@ int pm_clk_init(struct device *dev)
}

INIT_LIST_HEAD(&pcd->clock_list);
mutex_init(&pcd->lock);
spin_lock_init(&pcd->lock);
dev->power.subsys_data = pcd;
return 0;
}
Expand All @@ -181,12 +181,12 @@ void pm_clk_destroy(struct device *dev)

dev->power.subsys_data = NULL;

mutex_lock(&pcd->lock);
spin_lock_irq(&pcd->lock);

list_for_each_entry_safe_reverse(ce, c, &pcd->clock_list, node)
__pm_clk_remove(ce);

mutex_unlock(&pcd->lock);
spin_unlock_irq(&pcd->lock);

kfree(pcd);
}
Expand Down Expand Up @@ -220,13 +220,14 @@ int pm_clk_suspend(struct device *dev)
{
struct pm_clk_data *pcd = __to_pcd(dev);
struct pm_clock_entry *ce;
unsigned long flags;

dev_dbg(dev, "%s()\n", __func__);

if (!pcd)
return 0;

mutex_lock(&pcd->lock);
spin_lock_irqsave(&pcd->lock, flags);

list_for_each_entry_reverse(ce, &pcd->clock_list, node) {
if (ce->status == PCE_STATUS_NONE)
Expand All @@ -238,7 +239,7 @@ int pm_clk_suspend(struct device *dev)
}
}

mutex_unlock(&pcd->lock);
spin_unlock_irqrestore(&pcd->lock, flags);

return 0;
}
Expand All @@ -251,13 +252,14 @@ int pm_clk_resume(struct device *dev)
{
struct pm_clk_data *pcd = __to_pcd(dev);
struct pm_clock_entry *ce;
unsigned long flags;

dev_dbg(dev, "%s()\n", __func__);

if (!pcd)
return 0;

mutex_lock(&pcd->lock);
spin_lock_irqsave(&pcd->lock, flags);

list_for_each_entry(ce, &pcd->clock_list, node) {
if (ce->status == PCE_STATUS_NONE)
Expand All @@ -269,7 +271,7 @@ int pm_clk_resume(struct device *dev)
}
}

mutex_unlock(&pcd->lock);
spin_unlock_irqrestore(&pcd->lock, flags);

return 0;
}
Expand Down Expand Up @@ -344,19 +346,20 @@ int pm_clk_suspend(struct device *dev)
{
struct pm_clk_data *pcd = __to_pcd(dev);
struct pm_clock_entry *ce;
unsigned long flags;

dev_dbg(dev, "%s()\n", __func__);

/* If there is no driver, the clocks are already disabled. */
if (!pcd || !dev->driver)
return 0;

mutex_lock(&pcd->lock);
spin_lock_irqsave(&pcd->lock, flags);

list_for_each_entry_reverse(ce, &pcd->clock_list, node)
clk_disable(ce->clk);

mutex_unlock(&pcd->lock);
spin_unlock_irqrestore(&pcd->lock, flags);

return 0;
}
Expand All @@ -369,19 +372,20 @@ int pm_clk_resume(struct device *dev)
{
struct pm_clk_data *pcd = __to_pcd(dev);
struct pm_clock_entry *ce;
unsigned long flags;

dev_dbg(dev, "%s()\n", __func__);

/* If there is no driver, the clocks should remain disabled. */
if (!pcd || !dev->driver)
return 0;

mutex_lock(&pcd->lock);
spin_lock_irqsave(&pcd->lock, flags);

list_for_each_entry(ce, &pcd->clock_list, node)
clk_enable(ce->clk);

mutex_unlock(&pcd->lock);
spin_unlock_irqrestore(&pcd->lock, flags);

return 0;
}
Expand Down
1 change: 1 addition & 0 deletions drivers/tty/serial/sh-sci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1913,6 +1913,7 @@ static int __devinit sci_init_single(struct platform_device *dev,

port->dev = &dev->dev;

pm_runtime_irq_safe(&dev->dev);
pm_runtime_enable(&dev->dev);
}

Expand Down

0 comments on commit c11a7e2

Please sign in to comment.