drivers/net/macvtap: fix error check

'len' is unsigned of type size_t and can't be negative. Signed-off-by: Nicolas Kaiser <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Signed-off-by: David S. Miller <[email protected]>
yshchan · Mar 7, 2011 · ce3c869 · ce3c869
1 parent b3ca9b0
commit ce3c869
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
@@ -528,8 +528,9 @@ static ssize_t macvtap_get_user(struct macvtap_queue *q,
 		vnet_hdr_len = q->vnet_hdr_sz;
 
 		err = -EINVAL;
-		if ((len -= vnet_hdr_len) < 0)
+		if (len < vnet_hdr_len)
 			goto err;
+		len -= vnet_hdr_len;
 
 		err = memcpy_fromiovecend((void *)&vnet_hdr, iv, 0,
 					   sizeof(vnet_hdr));