elf: fix one check-after-use

Check before use it. Signed-off-by: WANG Cong <[email protected]> Cc: Alexander Viro <[email protected]> Cc: David Howells <[email protected]> Acked-by: Roland McGrath <[email protected]> Acked-by: James Morris <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
yshchan · Jul 1, 2009 · e2dbe12 · e2dbe12
1 parent 2027bd9
commit e2dbe12
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
@@ -1522,11 +1522,11 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
 	info->thread = NULL;
 
 	psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL);
-	fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
-
 	if (psinfo == NULL)
 		return 0;
 
+	fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
+
 	/*
 	 * Figure out how many notes we're going to need for each thread.
 	 */