Skip to content

Commit

Permalink
Merge pull request go-restruct#16 from johnwchadwick/size-of
Browse files Browse the repository at this point in the history
Implement SizeOf function. (Fixes go-restruct#7)
  • Loading branch information
jchv authored Jun 17, 2017
2 parents 213c589 + 2f23983 commit 00628ff
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 10 deletions.
36 changes: 26 additions & 10 deletions packing.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,15 @@ import (
"reflect"
)

func fieldFromIntf(v interface{}) (field, reflect.Value) {
val := reflect.ValueOf(v)
if val.Kind() == reflect.Ptr {
val = val.Elem()
}
f := fieldFromType(val.Type())
return f, val
}

/*
Unpack reads data from a byteslice into a value.
Expand Down Expand Up @@ -69,16 +78,27 @@ func Unpack(data []byte, order binary.ByteOrder, v interface{}) (err error) {
}
}()

val := reflect.ValueOf(v)
if val.Kind() == reflect.Ptr {
val = val.Elem()
}
f, val := fieldFromIntf(v)
d := decoder{order: order, buf: data}
d.read(fieldFromType(val.Type()), val)
d.read(f, val)

return
}

/*
SizeOf returns the serialized size of the structure passed, in memory.
*/
func SizeOf(v interface{}) (size int, err error) {
defer func() {
if r := recover(); r != nil {
err = r.(error)
}
}()

f, val := fieldFromIntf(v)
return f.SizeOf(val), nil
}

/*
Pack writes data from a datastructure into a byteslice.
Expand All @@ -96,11 +116,7 @@ func Pack(order binary.ByteOrder, v interface{}) (data []byte, err error) {
}
}()

val := reflect.ValueOf(v)
if val.Kind() == reflect.Ptr {
val = val.Elem()
}
f := fieldFromType(val.Type())
f, val := fieldFromIntf(v)
data = make([]byte, f.SizeOf(val))

e := encoder{buf: data, order: order}
Expand Down
5 changes: 5 additions & 0 deletions packing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,11 @@ func TestUnpack(t *testing.T) {
data, err := Pack(binary.BigEndian, v.Interface())
assert.Nil(t, err)
assert.Equal(t, test.data, data)

// Test sizing
size, err := SizeOf(v.Interface())
assert.Nil(t, err)
assert.Equal(t, len(test.data), size)
}
}

Expand Down

0 comments on commit 00628ff

Please sign in to comment.