Fix determination of staked QUIC connections (solana-labs#34760)

* Fix determination of staked QUIC connections * address review comments * review comments * treat connections with zero stake as unstaked
yu3ver · Jan 14, 2024 · f92275b · f92275b
1 parent 9468996
commit f92275b
Show file tree

Hide file tree

Showing 3 changed files with 184 additions and 241 deletions.
diff --git a/quic-client/src/lib.rs b/quic-client/src/lib.rs
@@ -133,21 +133,21 @@ impl QuicConfig {
     }
 
     fn compute_max_parallel_streams(&self) -> usize {
-        let (client_type, stake, total_stake) =
+        let (client_type, total_stake) =
             self.maybe_client_pubkey
-                .map_or((ConnectionPeerType::Unstaked, 0, 0), |pubkey| {
+                .map_or((ConnectionPeerType::Unstaked, 0), |pubkey| {
                     self.maybe_staked_nodes.as_ref().map_or(
-                        (ConnectionPeerType::Unstaked, 0, 0),
+                        (ConnectionPeerType::Unstaked, 0),
                         |stakes| {
                             let rstakes = stakes.read().unwrap();
                             rstakes.get_node_stake(&pubkey).map_or(
-                                (ConnectionPeerType::Unstaked, 0, rstakes.total_stake()),
-                                |stake| (ConnectionPeerType::Staked, stake, rstakes.total_stake()),
+                                (ConnectionPeerType::Unstaked, rstakes.total_stake()),
+                                |stake| (ConnectionPeerType::Staked(stake), rstakes.total_stake()),
                             )
                         },
                     )
                 });
-        compute_max_allowed_uni_streams(client_type, stake, total_stake)
+        compute_max_allowed_uni_streams(client_type, total_stake)
     }
 
     pub fn update_client_certificate(