Fix the use of List interface instead of ArrayList implementation

yuanchao7644920 · Aug 10, 2015 · 9785ab4 · 9785ab4
1 parent 40a0c90
commit 9785ab4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -11,7 +11,7 @@ The usage is pretty straightforward. Add the tag into the XML layout, then use t
 
 ```sh
  NiceSpinner niceSpinner = (NiceSpinner) findViewById(R.id.nice_spinner);
- ArrayList<String> dataset = new ArrayList<>(Arrays.asList("One", "Two", "Three", "Four", "Five"));
+ List<String> dataset = new LinkedList<>(Arrays.asList("One", "Two", "Three", "Four", "Five"));
  niceSpinner.attachDataSource(dataset);
 ```
 

diff --git a/src/main/java/org/angmarch/views/NiceSpinner.java b/src/main/java/org/angmarch/views/NiceSpinner.java
@@ -24,7 +24,7 @@
 import android.widget.PopupWindow;
 import android.widget.TextView;
 
-import java.util.ArrayList;
+import java.util.List;
 
 /**
  * @author angelo.marchesin
@@ -197,7 +197,7 @@ public void setOnItemSelectedListener(AdapterView.OnItemSelectedListener onItemS
         mOnItemSelectedListener = onItemSelectedListener;
     }
 
-    public <T> void attachDataSource(@NonNull ArrayList<T> dataset) {
+    public <T> void attachDataSource(@NonNull List<T> dataset) {
         mAdapter = new NiceSpinnerAdapter<>(getContext(), dataset);
         setAdapterInternal();
     }