Skip to content

Commit

Permalink
benchmarks: add set -o pipefail
Browse files Browse the repository at this point in the history
It seems that our automated benchmarks job was failing to build for the
last several days, but we didn't notice because it didn't use
'pipefail'. Thus the 'make | tee build.log' failure didn't actually
cause the script to exit with a bad status code, and we kept running the
binaries from a previous revision.

Change-Id: I6ab66e85cf39c6513da61e472c85e34da77205fc
Reviewed-on: http://gerrit.cloudera.org:8080/7123
Reviewed-by: Alexey Serbin <[email protected]>
Reviewed-by: Adar Dembo <[email protected]>
Tested-by: Todd Lipcon <[email protected]>
  • Loading branch information
toddlipcon committed Jun 8, 2017
1 parent 9ae11e6 commit 557f19e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/kudu/scripts/benchmarks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
# Jenkins job: http://sandbox.jenkins.cloudera.com/job/kudu-benchmarks
########################################################################

# Fail the job if any part fails, even when piping through 'tee', etc.
set -o pipefail

################################################################
# Constants
################################################################
Expand Down

0 comments on commit 557f19e

Please sign in to comment.